Skip to content
GitLab

feat(typescript-axios): add explicit override modifier

Closed Administrator requested to merge github/fork/dschu-lab/feat-axios-add-explicit-overrides into master

Created by: dschu-lab

Introducing the following changes

  • Updated minimum typescript version to ^4.3
  • Added override modifier to base api template
  • Updated samples

Motivation

The setting noImplicitOverride leads to a more robust codebase. Even if the option is not activated, the class still works if at least TS 4.3 is installed.

References

Pinging the commitee for visibility

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.