Skip to content
GitLab

[cpp-restsdk] Add support for json dialect types and some code refactoring

Open Administrator requested to merge github/fork/SanjayMarreddi/json_support into master

Created by: SanjayMarreddi

Hi, Our application is using json+ld (see more details at https://json-ld.org/) and use the following media type: application/ld+json. The current implementation of the CppRestSDK client ( modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/api-source.mustache ) does not support json dialects but only application/json. This PR contains:

  1. A refactoring to split the content type selection from the serialization/deserialization logic.
  2. Add a helper function to parse the content type and determine if it is a json dialect. To do so, firstly it checks if the value application/json (O(1)) is present in the hash map, and then iterates on all the values of the hashmap until finding a dialect by running a regex matching with the following pattern: application/([a-zA-Z0-9]+\+)?json

Testing:

I tested the build of a OpenAPI C++ client using a spec file that uses "application/ld+json" and it succeeded without any error.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.