Created by: avandecreme
The first commit fix the constructor of object taking an array of numbers as parameter, for example:
{ foo: [1, 2] }
I removed the check entirely because I am not sure by what to replace it, I would be happy to change it for any suggestion.
The second commit fix the toJSONString implementation for objects having a non-integer field, for example:
{ bar: 1.2 }
Note that only 6 decimals get kept, I am not sure how to keep all relevant decimals without having a bunch of zeros appended.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
In case you are adding a new generator, run the following additional script : Commit all changed files../bin/utils/ensure-up-to-date.sh -
File the PR against the correct branch: master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.