Skip to content
GitLab

[PHP-Symfony] Fixes #14930

Merged Guillaume Turri requested to merge github/fork/gturri/fix_14930 into master

This fixes the issues described on #14930 (closed) , ie: it fixes the parsing of date-time parameter, as well as non-required date-time parameters. All the details are either on the bug report and on commit messages.

This PR can be tested by setting up a Symfony app with autogenerated code using the openapi file described on #14930 (closed) and performing the queries:

curl -i http://localhost:8000/my-route  # with this PR it leads to a 200 response (instead of 400 with current master)
curl -i http://localhost:8000/my-route?myparam=2017-07-21T12:34:56Z # this also returns 200 with this PR instead of a 400

(since this is PHP I guess I should ping @jebentier, @dkarlovi , @mandrean, @jfastnacht , @ybelenko @renepardon (sorry in advance for the noise if I misunderstood that guideline))

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script : 
    ./bin/utils/ensure-up-to-date.sh
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.